FAKE_NPC having a sprite

[patrickkuhlmann]

Issue Prelude

• I have not modified the source prior to reproducing this issue.
• I am using the latest version of Hercules.
• I am aware that this report will be closed or deleted if it becomes obvious that I am stating the false.

Description

The FAKE_NPC is having a sprite with the latest stable version.
This can be seen here

Operating System

No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.3 LTS
Release: 16.04
Codename: xenial

[dastgirp]

Related PR: #1893
@4144

[dastgirp]

Suggested fix:
npc_refresh

if (map->list[nd->bl.m].users) {

To

if (map->list[nd->bl.m].users && nd->class_ != FAKE_NPC) {

[4144]

@dastgir if this fixed issue, can you create pr?

[bWolfie]

how come fake_npc has sprite of female novice to begin with @_@
what i mean is how come female novice not something else :P

Also I tested that @dastgir no luck sorry

[MishimaHaruna]

Suggested fix:

diff --git i/src/map/npc.c w/src/map/npc.c
index 10ff4ebf2..9e1414f9c 100644
--- i/src/map/npc.c
+++ w/src/map/npc.c
@@ -2708,7 +2708,7 @@ struct npc_data *npc_create_npc(enum npc_subtype subtype, int m, int x, int y, u
 	nd->area_size = AREA_SIZE + 1;
 	nd->class_ = class_;
 	nd->speed = 200;
-	nd->vd.class = 0;
+	nd->vd.class = INVISIBLE_CLASS;
 
 	return nd;
 }