Fix invisible NPCs (such as FAKE_NPC) showing up as Novice #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct view data (INVISIBLE_CLASS) when initializing new NPCs. The issue was introduced in HerculesWS#1893 Fixes HerculesWS#1916 Signed-off-by: Haru <haru@dotalux.com>
ghost
added
the
status:inprogress
|
This change is |
4144
approved these changes
Nov 28, 2017
ghost
removed
the
status:inprogress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Changes the NPC initialization code to use the correct view data (
INVISIBLE_CLASS) instead of the novice class ID (0).Related to #1893
Affected Branches:
Issues addressed:
Known Issues and TODO List
N/A