Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit dimensional gap #1431

Merged
merged 6 commits into from
Oct 3, 2016
Merged

Initial commit dimensional gap #1431

merged 6 commits into from
Oct 3, 2016

Conversation

Ridley8819
Copy link

@Ridley8819 Ridley8819 commented Sep 13, 2016

  • original script by RagnarokNova rathena/rathena@7d0c7d8
    full credits to him.
  • removed onchat labels, added a variable to check for the timer instead of using enable/disablenpc and 3 npcs on 1 location
  • using constants
  • simplified script

This change is Reviewable

@MishimaHaruna MishimaHaruna added the status:inprogress Issue is being worked on / the pull request is still a WIP label Sep 13, 2016
@Ridley8819 Ridley8819 added component:scripts Affecting the scripts and NPCs status:code-review Awaiting code review and removed status:inprogress Issue is being worked on / the pull request is still a WIP labels Sep 13, 2016
Ridley added 3 commits September 13, 2016 22:06
removed double space/ at end of line
removed leftover of Party Leader#dali2
somewthing messed up and changed wrong file
removed double space/ at end of line
removed leftover of Party Leader#dali2
}

dali,117,81,7 script Party Member#WANDERER 4_F_WANDERER,{
end;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These Party Member NPC's don't do anything?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing except the npctalk triggered by the leader

@dastgirp
Copy link
Member

Anything left?

@dastgirp dastgirp self-assigned this Sep 30, 2016
OnInit:
sellitem Spectacles;
sellitem Arrow;
sellitem Booby_Trap;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing end;
(It would however end with this too, but having end; would be nice)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, thank you for mentioning it.

mes("Is this place the famous Prontera? It is dark just like a big city!");
next();
mes("[Traveller]");
mes("I hear a ticking clock. This place must be Geffen!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all these npc show same 4-5 text, is it random? or they show this everytime in same order?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, same order (but depending which npc you talk to)

@dastgirp dastgirp merged commit 0dd3f6f into HerculesWS:master Oct 3, 2016
@dastgirp dastgirp removed the status:code-review Awaiting code review label Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scripts Affecting the scripts and NPCs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants