*delwall now give a friendly warning to remind non-existent wall #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
ehh .... woot ... why go to stable branch ... let me recheck what happening ... EDIT: okies ~ |
4144
approved these changes
Apr 10, 2018
|
rathena/rathena@6ceb1bd |
bWolfie
reviewed
Apr 13, 2018
|
|
||
| if (!map->iwall_remove(name)) { | ||
| ShowWarning("buildin_delwall: Non-existent '%s' provided.\n", name); | ||
| return false; |
There was a problem hiding this comment.
since you already showing warning, isn't it better to return true?
There was a problem hiding this comment.
rathena there also SCRIPT_CMD_FAILURE, so what's wrong ?
return false just means print an info message of the source npc
#868
There was a problem hiding this comment.
cos spammy on console kinda
There was a problem hiding this comment.
I believe that printing the message about the source NPC makes sense (so you can easily find and fix the broken script that causes the warnings)
Asheraf
approved these changes
Apr 16, 2018
Asheraf
added
type:enhancement
MishimaHaruna
approved these changes
Apr 22, 2018
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
*delwall now give a friendly warning to remind non-existent wall
Affected Branches:
master
Issues addressed:
rathena/rathena#3025
in my battleground script, after I *setwall, but I delwall twice,
and the server didn't even print any error message
Known Issues and TODO List
check the 3rd commit, I missed that delwall thing
and I blame it on the script command itself XD