-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move configs to new Unit Parameters DB and Max HP limits #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asheraf
reviewed
Jun 8, 2023
this will make it easier to extend with new deprecations/removals
this new db will allow splitting certain battle configs into pre-re/re versions and fine tune them in configuration groups associated to each job. this commit only contains the base file reading. fields will come in follow up commits
09b1837
to
6fec984
Compare
MishimaHaruna
requested changes
Jun 14, 2023
- this removed max_hp battle config - it is now possible to create different MaxHP values depending on the player's level
From Episode 15.1 update - from Lvl 1 to Lvl 99: 330,000 - from Lvl 100 to Lvl 150: 660,000 - from LVl 151 to Lvl 175: 1,100,000
max_third_aspd battle conf is also removed because it can be set using unit parameters
- pc_maxparemeter macro is also renamed to pc_maxstats - some max_parameter configs are kept because they are required for other logics
this prepares the code for future renewal update where natural heal weight has changed. - pc_is50overweight macro is now called pc_isoverhealweight to avoid confusion
6fec984
to
6915e41
Compare
MishimaHaruna
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This PR creates a new db file called Unit Parameters DB and moves a few battle configs to it:
The reason to move those settings is that:
Thus having this new file allows us to link jobs to parameter groups for each server type.
Finally, a small change but an actual new content: This PR also adds the maximum HP based on users level. A change introduced in kRO's episode 15.1
Huge thanks to Haru and 4144 for the discussions on this :)
Issues addressed: MaxHP limits item from #243
For users upgrading their Hercules copy
(I plan to also post this on herc board once the PR gets in a release)
There are 3 changes introduced in this PR that may affect you.
1. job_db.conf update
If you are using Hercules' default db folder (
db/pre-re/job_db.conf
ordb/re/job_db.conf
) this should get merged automatically.For custom folders, please check the original Hercules'
job_db.conf
and replicate theParametersGroup
of each job. Using the same values as in Hercules' original file will make the other 2 changes easier to migrate.2. You must have the new
unit_parameters_db.conf
db fileIf you are using Hercules' default db folder (
db/pre-re/
ordb/re/
) this should get merged automatically.For custom folders, please copy
db/(pre-re|re)/unit_parameters_db.conf
to your own db folder (based on your server type).Those will already come with the default configs and groups that you needed in step 1.
3. Migrate configs from
conf/battle/player.conf
If you have customized any of the configs changed in this PR, you may have to update your
unit_parameters_db.conf
with the new values. Below you will find each battle config and how they map to the newunit_parameters_db.conf
.natural_heal_weight_rate
NaturalHealWeightRate
Base
max_aspd
MaxASPD
Base
max_third_aspd
MaxASPD
ThirdClasses
SuperNovice
max_hp
MaxHP
Base
max_parameter
MaxStats
Base
max_third_parameter
MaxStats
ThirdClasses
max_extended_parameter
MaxStats
ExtendedClasses
max_summoner_parameter
MaxStats
Summoner
max_baby_parameter
MaxStats
BabyBase
max_baby_third_parameter
MaxStats
BabyThirdClasses