Fix *queuedel doesn't remove player's side queue #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishimaHaruna
added
the
status:inprogress
AnnieRuru
changed the title
|
damn ... I listed wrong script command name ... |
|
This should be fixed in #857 (by having |
|
ok, close this one once you merge your vector style ... thing |
MishimaHaruna
removed
the
status:inprogress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#846
I found out the reason
sd->queues[j] is the queue ID from the player
script->hq[idx].item[i] is the account ID of the queue in that array
so it was comparing wrong information
it should be comparing to idx instead
I also just check the
script_hqueue_clear,that function IS comparing to idx too