New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Shadow Issues #440

Merged
merged 4 commits into from Apr 27, 2018

Conversation

Projects
None yet
2 participants
@2blane
Contributor

2blane commented Apr 4, 2018

Shadows were being cutoff by the snapshots (because they use the bounds of the view and shadows exist outside the bounds), and then were applied again to the snapshot. This fix first removes the shadows, takes the snapshot, and then adds the shadows back to the snapshot much like the cornerRadius property.

Fixed Shadow Issues
Shadows were being cutoff by the snapshots, and then were applied again to the snapshot. This fix first removes the shadows, takes the snapshot, and then adds the shadows to the snapshot much like the cornerRadius.
@lkzhao

This comment has been minimized.

Show comment
Hide comment
@lkzhao

lkzhao Apr 12, 2018

Collaborator

This is great, just wondering if we should include shadowOpacity as well?

Collaborator

lkzhao commented Apr 12, 2018

This is great, just wondering if we should include shadowOpacity as well?

@2blane

This comment has been minimized.

Show comment
Hide comment
@2blane

2blane Apr 20, 2018

Contributor

Good catch, I just added the shadow opacity property.

Contributor

2blane commented Apr 20, 2018

Good catch, I just added the shadow opacity property.

@lkzhao lkzhao merged commit 7d61342 into HeroTransitions:master Apr 27, 2018

@lkzhao

This comment has been minimized.

Show comment
Hide comment
@lkzhao

lkzhao Apr 27, 2018

Collaborator

Thanks a lot!

Collaborator

lkzhao commented Apr 27, 2018

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment