[Windows] Shortcuts are not created properly if the game name has invalid characters

[Arron17]

IMPORTANT! Do not erase this template!

Is this a game issue? If YES please use our Discord to get help.

Open here only issues with Heroic like: Heroic doesn't open, some button is out of place, Heroic closes unexpectedly, installs got interrupted, etc.

Try to get help on our Wiki first: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Troubleshooting

Describe the bug
If you try to create a shortcut for a game that uses characters that are invalid in Windows File names, then the creation of the shortcuts do not complete correctly.

Add Logs
No Logs are produced when clicking on Add Shortcut

To Reproduce
Steps to reproduce the behavior:

1. Go to a game that uses special characters that Windows can't use in a file name, for example "while True: learn()"
2. Click on Add shortcut
3. Message will appear to say a shortcut has been created on the Desktop and Start Menu
4. Shortcut on the Desktop is created, however it is called while True, has no icon and is a zero byte file, not a shortcut.
5. No shortcut is made in the start menu at all

Expected behavior
Needs to have some logic on Windows that stops it from trying to use Invalid characters in the shortcut filenames, added example screenshot:

Desktop (please complete the following information):

• OS: Windows 11 21H2
• Heroic Version 1.11.0 Alpha
• Game: while True:learn()
• Wine/Proton version: N/A
• Hardware specs (RAM, CPU, GPU): N/A

[Arron17]

Would be linked to #740

[flavioislima]

I see. I'll try to fix this on next version!

[ghost]

Please assign it to me.

[flavioislima]

Please assign it to me.

Done!

[ghost]

Can you download this build here and see if it works now? @Arron17

[Arron17]

@dragonDScript Same problem unfortunately.

[ghost]

@dragonDScript Same problem unfortunately.

Have you deleted and created the shortcut again? It should work.

[Arron17]

@dragonDScript Deleted shortcut and tried it again, uninstalled the game and tried it again, changed the location of the game install and tried again. Same result each time.

[ghost]

OK I will test this myself.

[Dark-Matter7232]

Issue still exists.

[flavioislima]

Fixed