[Windows] Constantly prompting that a new version of a game is available

[Arron17]

IMPORTANT! Do not erase this template!

Is this a game issue? If YES please use our Discord to get help.

Open here only issues with Heroic like: Heroic doesn't open, some button is out of place, Heroic closes unexpectedly, installs got interrupted, etc.

Try to get help on our Wiki first: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Troubleshooting

Describe the bug
After installing a game Heroic constantly shows that a new version is available. Can only replicate with a single game, while True: learn().

Add Logs
`PS C:\Users\Arron\appdata\local\programs\heroic> .\Heroic.exe --enable-logging
PS C:\Users\Arron\appdata\local\programs\heroic>
INFO: Trying to get user information
INFO: Trying to get user information
INFO: Trying to get user information
INFO: Registered protocol with OS.
INFO: Frontend: Refreshing Library
INFO: Refreshing library...
INFO: Legendary: Refreshing Epic Games...
INFO: Refreshing Epic Games...
[cli] INFO: Logging in...

[Core] INFO: Trying to re-use existing login session...

[cli] INFO: Getting game list... (this may take a while)

INFO: Updating game list
INFO: Game List Updated
INFO: Checking for game updates
INFO: Found 1 game(s) to update
INFO: Trying to get user information
INFO: checking for heroic updates
INFO: Trying to get user information
INFO: Progress: 4f272a49a39742b795d63e1f483a7c7d undefined/undefinedMiB/undefined
INFO: finished updating
INFO: Progress: 4f272a49a39742b795d63e1f483a7c7d undefined/undefinedMiB/undefined
INFO: Frontend: Refreshing Library
INFO: Refreshing library...
INFO: Updating game list
INFO: Game List Updated
INFO: Checking for game updates
INFO: Found 1 game(s) to update
INFO: Trying to get user information
INFO: Progress: 4f272a49a39742b795d63e1f483a7c7d undefined/undefinedMiB/undefined
INFO: finished updating
INFO: Progress: 4f272a49a39742b795d63e1f483a7c7d undefined/undefinedMiB/undefined
INFO: Frontend: Refreshing Library
INFO: Refreshing library...
INFO: Updating game list
INFO: Game List Updated
INFO: Checking for game updates
INFO: Found 1 game(s) to update
INFO: Saving log file to C:\Users\Arron\AppData\Roaming\heroic\Crashpad/Thu Dec 02 2021.txt`

To Reproduce
Steps to reproduce the behavior:

1. Load up Heroic and select the "Updates" filter, it shows 1 update available

2. Click on "while True: learn()" Game.

3. Click the "Installed - New Version Available! (Click to Update) button.
   

4. Toast Message comes up "Update Cancelled"
   

Expected behavior
Heroic should not prompt that there is a New Version available if there isn't. And once a new version is installed it should stop prompting for updates.

Desktop (please complete the following information):

• OS: Windows 11 21H2
• Heroic Version: 1.11.0 Alpha & 1.10.3
• Game: while True: learn()
• Wine/Proton version: N/A
• Hardware specs (RAM, CPU, GPU): N/A

Additional context
Because this uses Legendary for the app downloads I tried to replicate the issue in that, however Legendary doesn't show there is an update available.

`PS F:\Downloads> .\legendary.exe list-installed --check-updates
[cli] INFO: Logging in to check for updates...
[Core] INFO: Trying to re-use existing login session...

Installed games:

• Absolute Drift (App name: 19927295d6e3467887d4e830d8c85963 | Version: Win_202108051533 | 0.33 GiB)
• while True: learn() (App name: 4f272a49a39742b795d63e1f483a7c7d | Version: 1.3.97.5144.35.win64 | 0.79 GiB)

Total: 2`

I tried a few other games but cannot replicate the issue with any other games.

[ghost]

Caused by #760

[flavioislima]

@dragonDScript This is caused by the name of the game. We need to use that Regexp to clean the game name everywhere. It's probably broken on some Json file we use to cache the library or the list of games with update.
I'll install this game to find the issue.

So maybe make that regexp a function that can be used anywhere in the Backend, maybe on a utils or constants file.

[flavioislima]

This is the line with the issue:

HeroicGamesLauncher/electron/legendary/library.ts

Line 228 in b3418e3

.filter((item) => item.includes('True'))

we need to improve the logic to show if the game has updates or not.

[flavioislima]

Fixed on Main branch.

[flavioislima]

Thanks for posting the issue @Arron17

[ghost]

How did you fix it? You made many changes. It'd be as simple as checking if while True: learn() is present and if it is, remove it.