Sanitize shortcuts #766
Sanitize shortcuts #766
Conversation
ghost
marked this pull request as ready for review
ghost
self-assigned this
|
I thibk you have removed the options from backend but is keeping on frontend. Need to remove from settings screen as well. |
|
I think that if this is to fix the issue, the pr could focus only on that part. Using regex to remove the special characters. |
I've removed them. And tested locally and the options weren't visible. |
OK I will work on the prompt on another PR but lets leave this PR as-is |
Ah OK. I'm blind and missed the changes on the settings file. |
…a empty space on it
OK fixed |
|
I think that this is ready to merge, what do you think @flavioislima |
Co-authored-by: Flávio F Lima <flavioislima@gmail.com>
|
@flavioislima OK I think we can merge now |
| if (process.platform === 'darwin') { | ||
| return | ||
| } | ||
|
|
||
| const gameInfo = await this.getGameInfo() | ||
| const launchWithProtocol = `heroic://launch/${gameInfo.app_name}` | ||
| const [ desktopFile, menuFile ] = this.shortcutFiles(gameInfo.title) | ||
| const { addDesktopShortcuts, addStartMenuShortcuts } = await GlobalConfig.get().getSettings() | ||
| const sanitizedTitle = gameInfo.title |
There was a problem hiding this comment.
Since the issue at #760 is on Windows, this actually doesn't fix it, since this title is used only on linux.
We need another solution for windows.
There was a problem hiding this comment.
What title is used in windows to create the shortcut filename?
Fixes #760
and adds a steam prompt like this:Prompt UI