Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] update .gitignore, UX improvements in webview #1106

Merged
merged 5 commits into from Mar 16, 2022

Conversation

dawidgarus
Copy link
Contributor

Various UX improvements in WebView component:

  • Disable back/forward button when operation is not possible
  • Added tooltips to buttons
  • Added a button to open current page in user's web browser
  • Changed icon of reload button
  • Added colors on hover and indication when user clicked on a button
  • User can now select URL
  • Changed color of URL to red when schema is not https
  • Changed size of the toolbar, gaps and added accent on the bottom for more pleasing look
  • Added .idea folder to .gitignore

Preview:
Screenshot from 2022-03-13 02-03-23


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@@ -323,6 +323,14 @@
"manageaccounts": "Manage Accounts",
"quit": "Quit"
},
"webview": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is important that you actually run yarn i18n so it will create this key with the default value for all language files. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged main and generated translations

flavioislima
flavioislima previously approved these changes Mar 15, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I believe you just need to run yarn i18n to fix the language files and we can merge it.

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 15, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good! ⚔️

@flavioislima flavioislima merged commit 92dfaf6 into Heroic-Games-Launcher:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants