New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[General] update .gitignore, UX improvements in webview #1106
Conversation
@@ -323,6 +323,14 @@ | |||
"manageaccounts": "Manage Accounts", | |||
"quit": "Quit" | |||
}, | |||
"webview": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is important that you actually run yarn i18n
so it will create this key with the default value for all language files. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged main and generated translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I believe you just need to run yarn i18n
to fix the language files and we can merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good! ⚔️
Various UX improvements in WebView component:
Preview:
Use the following Checklist if you have changed something on the Backend or Frontend: