Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic shortcuts creation #1903

Merged
merged 1 commit into from Oct 17, 2022
Merged

Fix automatic shortcuts creation #1903

merged 1 commit into from Oct 17, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 14, 2022

I noticed the feature to automatically add games to the desktop/menu was not working, and seems like I broke it a year ago https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/740/files 馃檲

This PR re-adds the method call to addShortcuts that takes care of adding the shortcuts after a game is installed if needed.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 14, 2022
@arielj arielj mentioned this pull request Oct 14, 2022
Merged
4 tasks
@flavioislima flavioislima requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team October 14, 2022 09:35
@arielj arielj merged commit 0256de3 into beta Oct 17, 2022
@arielj arielj deleted the fixes/automatic-shortcuts branch October 17, 2022 03:03
@arielj arielj mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommandMC CommandMC CommandMC approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arielj @CommandMC