Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortcuts to Steam automatically #1904

Merged
merged 6 commits into from Oct 19, 2022
Merged

Add shortcuts to Steam automatically #1904

merged 6 commits into from Oct 19, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 14, 2022

This PR fixes #1868 adding the setting to automatically add games to Steam after installation.

I'll add some notes in the diff to clarify some of the changes.

This branch is branched from #1903, if 1903 gets merged first we may need to change the base of this PR before merging!

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 14, 2022
@arielj arielj linked an issue Oct 14, 2022 that may be closed by this pull request
Feature: Automatically add to Steam #1868
Closed
@flavioislima flavioislima requested review from a team, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team October 14, 2022 09:34
Base automatically changed from fixes/automatic-shortcuts to beta October 17, 2022 03:03
flavioislima
flavioislima approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here and looks fine 👍🏽

@arielj arielj merged commit 25df80d into beta Oct 19, 2022
@arielj arielj deleted the feature/automatic-steam-shortcuts branch October 19, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommandMC CommandMC CommandMC left review comments

@flavioislima flavioislima flavioislima approved these changes

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

@redromnon redromnon Awaiting requested review from redromnon redromnon was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Automatically add to Steam
3 participants
@arielj @flavioislima @CommandMC