Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General/Protocol] Fix protocol not launching gog games #1969

Merged

Conversation

imLinguin
Copy link
Member

@imLinguin imLinguin commented Oct 31, 2022

This fixes the issue we discovered on latest 2.5.0.beta.1 release that prevents gog games from launching using protocol.
Fixed it by checking for underlying value of a object returned by getGameInfo methods, since empty object {} is always true in boolean expressions

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

src/backend/protocol.ts Outdated Show resolved Hide resolved
src/backend/protocol.ts Outdated Show resolved Hide resolved
@flavioislima
Copy link
Member

I am not sure why the tests are falling only now but might be related to some changes I did on my Fixes PR before the beta.
I changed where we check if the logs exist to fix an error on BE when the game has no logs.
So the current tests for that might not be relevant and maybe could be removed/Adapted. But we would need to investigate on that.

@flavioislima flavioislima requested review from a team, arielj, flavioislima, Nocccer and redromnon and removed request for a team November 1, 2022 09:26
@imLinguin
Copy link
Member Author

Tested Epic, GOG and sideload all work fine

@imLinguin imLinguin added the pr:ready-to-merge This PR is fully ready for merge. label Nov 1, 2022
@flavioislima flavioislima merged commit 10b3c6b into Heroic-Games-Launcher:beta Nov 1, 2022
@imLinguin imLinguin deleted the fix/gog_protocol_launching branch November 1, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants