New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Proper kill wine processes when hitting Stop Button #2666

Merged

flavioislima merged 1 commit into Heroic-Games-Launcher:main from Etaash-mathamsetty:fix-killing-wine

May 2, 2023

Member

Etaash-mathamsetty commented May 2, 2023

also was broken by the refactor, and seems to have broken sideloaded apps, legendary, and gog on macOS, which is quite a lot lol.

Use the following Checklist if you have changed something on the Backend or Frontend:

Tested the feature and it's working on a current and clean install.
Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
Created / Updated Tests (If necessary)
Created / Updated documentation (If necessary)


          fix killing wine on non native games

588771e

flavioislima approved these changes

View reviewed changes

Member

flavioislima left a comment

LGTM

flavioislima changed the title ~~fix killing wine on non native games~~ [FIX] Proper kill wine processes when hitting Stop Button

flavioislima merged commit a1c1024 into Heroic-Games-Launcher:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet