Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial support for Unreal Marketplace. #286

Merged
merged 10 commits into from
Apr 9, 2021

Conversation

Kjell291
Copy link
Contributor

@Kjell291 Kjell291 commented Mar 31, 2021

Added initial support for the unreal engine marketplace as requested in #257.
There still is much room for improvement, but it's working.
To install a package one should select the project folder located in ~/Documents/Unreal Projects.

Fixes #257.

Heroic01
Heroic02
Heroic03
Heroic04
Heroic05

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, man! I think this feature will be really useful for devs in general and I received this request since Heroic's first release but I had no idea on how to implement it!

codewise looks good, I just think that we might add another menu or switch for the market place since it is something specific for game devs.

I was thinking that we can have a submenu under Library with a link to show only the items under market place. What do you think? We can discuss that and ask for other devs review on our discord development channel.

@SaladinAyyub
Copy link

SaladinAyyub commented Mar 31, 2021

Thanks for this ! The thing that is missing.

We can download assets to the project however Marketplace also has whole project samples which simply gets installed in "Unreal Projects" directory. like this one (https://www.unrealengine.com/marketplace/en-US/product/cesium-samples
) for this EGS requires Unreal Engine to be detected as it sets up the whole project. We can have option in Heroic to choose engine directory as people install it in different paths. Or just install the sample project and user has to setup and build it themselves which is fine anyway.

@adityaruplaha
Copy link
Contributor

This will cause severe conflicts with the Electron refactor as this entire module is being overhauled. So I strongly advise against merging this right now.
Also the OOP approach should clean up this code further.

So please, hold your merge for a week or two. I'll try to review it in a few hours.

If after the refactor the code looks too complex to add this (which it shouldn't really), I'll do it myself, and add @Kjell291 as co-author. Sounds good? Sorry about stalling development.

@Kjell291
Copy link
Contributor Author

Kjell291 commented Apr 1, 2021

Thanks for all the feedback.
I will continue working on this.

codewise looks good, I just think that we might add another menu or switch for the market place since it is something specific for game devs.

I was thinking that we can have a submenu under Library with a link to show only the items under market place. What do you think? We can discuss that and ask for other devs review on our discord development channel.

Another menu would be a good idea with the option to filter for specific Engine versions.

ianwijma
ianwijma previously approved these changes Apr 1, 2021
Copy link
Contributor

@ianwijma ianwijma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complains from my end beside the points already made

Copy link
Contributor

@adityaruplaha adityaruplaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If the tests go fine, I'll merge this.

@adityaruplaha adityaruplaha added feature-request New feature needs to be implemented. pr:ready-to-merge This PR is fully ready for merge. labels Apr 9, 2021
@adityaruplaha adityaruplaha changed the title added support for unreal marketplace feat: Add support for Unreal Marketplace. Apr 9, 2021
@adityaruplaha adityaruplaha changed the title feat: Add support for Unreal Marketplace. feat: Add initial support for Unreal Marketplace. Apr 9, 2021
@adityaruplaha adityaruplaha merged commit 6fa9dc0 into Heroic-Games-Launcher:main Apr 9, 2021
@adityaruplaha adityaruplaha modified the milestone: 1.5.8 Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature needs to be implemented. pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreal Engine marketplace integration.
5 participants