-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add initial support for Unreal Marketplace. #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, man! I think this feature will be really useful for devs in general and I received this request since Heroic's first release but I had no idea on how to implement it!
codewise looks good, I just think that we might add another menu or switch for the market place since it is something specific for game devs.
I was thinking that we can have a submenu under Library with a link to show only the items under market place. What do you think? We can discuss that and ask for other devs review on our discord development channel.
Thanks for this ! The thing that is missing. We can download assets to the project however Marketplace also has whole project samples which simply gets installed in "Unreal Projects" directory. like this one (https://www.unrealengine.com/marketplace/en-US/product/cesium-samples |
This will cause severe conflicts with the Electron refactor as this entire module is being overhauled. So I strongly advise against merging this right now. So please, hold your merge for a week or two. I'll try to review it in a few hours. If after the refactor the code looks too complex to add this (which it shouldn't really), I'll do it myself, and add @Kjell291 as co-author. Sounds good? Sorry about stalling development. |
Thanks for all the feedback.
Another menu would be a good idea with the option to filter for specific Engine versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No complains from my end beside the points already made
…nstall/copy manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If the tests go fine, I'll merge this.
Added initial support for the unreal engine marketplace as requested in #257.
There still is much room for improvement, but it's working.
To install a package one should select the project folder located in ~/Documents/Unreal Projects.
Fixes #257.