Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert printing winetricks packages in logs #3405

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 7, 2024

Similar to #3404

With the new information in the logs, one of the lines was the list of winetricks packages installed. The problem is that, when the prefix is not yet created, this call to get the winetricks packages initializes the prefix at the wrong point of the process and all the setup code is skipped.

I'll revert this for now, in the future I'll make change some of this to add the logs only after the prefix is ready.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 7, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 7, 2024 01:19
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj arielj merged commit 8bdee13 into main Jan 7, 2024
9 checks passed
@arielj arielj deleted the revert-winetricks-in-logs branch January 7, 2024 01:38
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants