Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comet support #3727

Merged
merged 21 commits into from
Aug 4, 2024
Merged

comet support #3727

merged 21 commits into from
Aug 4, 2024

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented Apr 28, 2024 •
edited
Loading

depends on #3849 (do not merge until that gets merged)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Apr 28, 2024 •
edited
Loading

doesn't cause games to crash and allows for multiplayer functionality and achievements (in a few games) might be a good enough initial version

Etaash-mathamsetty and others added 4 commits July 11, 2024 19:04
@Etaash-mathamsetty
comet support (doesn't include comet binaries)
feec5c3
@Etaash-mathamsetty
use --quit flag
68f3b24
@Etaash-mathamsetty @imLinguin
gog online presence support
8fd57d1 
Co-Authored-By: Paweł Lidwin <linguin@tutanota.com>
@Etaash-mathamsetty @arielj
code review suggestions
faf2034 
Co-authored-by: Ariel Juodziukynas <arieljuod@gmail.com>
@Etaash-mathamsetty Etaash-mathamsetty changed the title comet support (doesn't include comet binaries) comet support Jul 11, 2024
@arielj arielj added this to the 2.15.0 milestone Jul 13, 2024
@imLinguin
Copy link
Member

imLinguin commented Jul 29, 2024 •
edited
Loading

Things to address

  • Make comet a experimental feature (enabled by default)
  • Download and install comet's dummy-service (possibly with versioning in case we needed to update it in the future)
  • Add an option to disable GOG online presence (maybe merge it with playtime option?)

@Lariaa Lariaa mentioned this pull request Jul 31, 2024
Closed
@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 31, 2024
@imLinguin imLinguin requested a review from a team July 31, 2024 13:48
@imLinguin imLinguin requested review from arielj, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team July 31, 2024 13:48
CommandMC
CommandMC reviewed Jul 31, 2024
View reviewed changes
src/backend/launcher.ts Outdated Show resolved Hide resolved
@imLinguin imLinguin mentioned this pull request Aug 1, 2024
Closed
@imLinguin imLinguin linked an issue Aug 2, 2024 that may be closed by this pull request
Allow online play with GOG #3852
Closed
@CommandMC
Merge branch 'refs/heads/main' into comet
1f3464d 
# Conflicts:
#	src/frontend/screens/Settings/components/ExperimentalFeatures.tsx
#	src/frontend/state/ContextProvider.tsx
#	src/frontend/state/GlobalState.tsx
@imLinguin imLinguin merged commit 6828379 into main Aug 4, 2024
8 of 9 checks passed
@imLinguin imLinguin deleted the comet branch August 4, 2024 15:48
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CommandMC CommandMC CommandMC left review comments

@imLinguin imLinguin imLinguin approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

Allow online play with GOG
4 participants
@Etaash-mathamsetty @imLinguin @arielj @CommandMC