Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SortedSet and ReadOnlyCollection<T> are not supported #8

Open
gkronber opened this issue Apr 19, 2019 · 3 comments
Open

SortedSet and ReadOnlyCollection<T> are not supported #8

gkronber opened this issue Apr 19, 2019 · 3 comments

Comments

@gkronber
Copy link
Member

I tried to serialize a type with a field of type IReadOnlyList<...>.

The types in System.Collections.Generic should be rechecked to make sure we have registered all the required types.
@gkronber
Copy link
Member Author

Same for SortedSet

gkronber added a commit that referenced this issue Apr 24, 2019
@gkronber
#8 Add unit test for more collections.
9857f8c
gkronber added a commit that referenced this issue Apr 27, 2019
@gkronber
#8 Register more types from System.Collections and System.Collections…
57191a5 
….Generic
jkarder added a commit that referenced this issue May 15, 2019
@jkarder
#8 Add support for System.Collections.Generic.SortedSet<T>
7919d9a 
This commit renames HashSetTransformer<T> to SetTransformer<T> and lets it transform objects of type System.Collections.Generic.SortedSet<T>.
jkarder added a commit that referenced this issue May 15, 2019
@jkarder
#8 Update list of supported types
91470f2 
Adds System.Collections.Generic.SortedSet<T> to the list of supported types.
@abeham
Copy link
Member

abeham commented Sep 4, 2019

It seems the two types explicitly mentioned in this issue are supported. IReadOnlyList seems supported (as of 57191a5) and SortedSet is supported (as of 91470f2). Can this issue be closed?

@gkronber
Copy link
Member Author

Indeed IReadOnlyList<> is supported already.

A transformer that handles ReadonlyCollection is missing.

@gkronber gkronber changed the title IReadOnlyList<T> is not registered as a StorableType SortedSet and ReadOnlyCollection<T> are not supported Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abeham @gkronber