Added changes for HipChat

Issue #58 fixed the alert to use camelCaseToTitleCase
HewlettPackard · Apr 21, 2017 · 29d9ece · 29d9ece
1 parent 228ee08
commit 29d9ece
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 19 deletions.
diff --git a/src/listener/utils/transforms/alert.js b/src/listener/utils/transforms/alert.js
@@ -40,6 +40,7 @@ export default class Alert extends Resource {
       if (this.__isNonDisplayField__(field) || !this[field]) {
         continue;
       }
+
       if (field === 'associatedResource') {
         fields.push({
           title: 'Resource',
@@ -48,7 +49,7 @@ export default class Alert extends Resource {
         });
       } else {
         fields.push({
-            title: field,
+            title: this.camelCaseToTitleCase(field),
             short: true,
             value: this[field]
           });
@@ -66,7 +67,7 @@ export default class Alert extends Resource {
       if (field === 'associatedResource') {
         output += '\t\u2022 Resource: ' + this[field].resourceName + '\n';
       } else {
-        output += '\t\u2022 ' + field + ': ' + this[field] + '\n';
+        output += '\t\u2022 ' + this.camelCaseToTitleCase(field) + ': ' + this[field] + '\n';
       }
     }
     //Add status to output only for HipChat

diff --git a/src/listener/utils/transforms/server-hardware.js b/src/listener/utils/transforms/server-hardware.js
@@ -44,10 +44,8 @@ export default class ServerHardware extends Resource {
         continue;
       }
 
-      let displayField = this.camelCaseToTitleCase(field);
-
       fields.push({
-        title: displayField,
+        title: this.camelCaseToTitleCase(field),
         short: true,
         value: this[field]
       });
@@ -77,7 +75,7 @@ export default class ServerHardware extends Resource {
       if (this.__isNonDisplayField__(field) || !this[field]) {
         continue;
       }
-      output += '\t\u2022 ' + field + ': ' + this[field] + '\n';
+      output += '\t\u2022 ' + this.camelCaseToTitleCase(field) + ': ' + this[field] + '\n';
     }
     if (this.serverProfileUri) {
       output += '\t\u2022 Profile: ' +  getDeviceName(this.serverProfileUri) + '\n';

diff --git a/src/listener/utils/transforms/server-profile-compliance-preview.js b/src/listener/utils/transforms/server-profile-compliance-preview.js
@@ -49,10 +49,8 @@ export default class ServerProfileCompliancePreview extends Resource {
         value = this[field];
       }
 
-      let displayField = this.camelCaseToTitleCase(field);
-
       fields.push({
-        title: displayField,
+        title: this.camelCaseToTitleCase(field),
         short: false,
         value: value
       });
@@ -73,7 +71,7 @@ export default class ServerProfileCompliancePreview extends Resource {
         value = this[field];
       }
       if (value) {
-        output += field + ':\n' + value + '\n';
+        output += this.camelCaseToTitleCase(field) + ':\n' + value + '\n';
       }
     }
     return output;

diff --git a/src/listener/utils/transforms/server-profile-template.js b/src/listener/utils/transforms/server-profile-template.js
@@ -39,10 +39,8 @@ export default class ServerProfileTemplate extends Resource {
         continue;
       }
 
-      let displayField = this.camelCaseToTitleCase(field);
-
       fields.push({
-        title: displayField,
+        title: this.camelCaseToTitleCase(field),
         short: true,
         value: this[field]
       });
@@ -56,7 +54,7 @@ export default class ServerProfileTemplate extends Resource {
       if (this.__isNonDisplayField__(field) || !this[field]) {
         continue;
       }
-      output += '\t\u2022 ' + field + ': ' + this[field] + '\n';
+      output += '\t\u2022 ' + this.camelCaseToTitleCase(field) + ': ' + this[field] + '\n';
     }
     return output;
   }

diff --git a/src/listener/utils/transforms/server-profile.js b/src/listener/utils/transforms/server-profile.js
@@ -43,10 +43,8 @@ export default class ServerProfile extends Resource {
         continue;
       }
 
-      let displayField = this.camelCaseToTitleCase(field);
-
       fields.push({
-        title: displayField,
+        title: this.camelCaseToTitleCase(field),
         short: true,
         value: this[field]
       });
@@ -67,7 +65,7 @@ export default class ServerProfile extends Resource {
       if (this.__isNonDisplayField__(field) || !this[field]) {
         continue;
       }
-      output += '\t\u2022 ' + field + ': ' + this[field] + '\n';
+      output += '\t\u2022 ' + this.camelCaseToTitleCase(field) + ': ' + this[field] + '\n';
     }
     if (this.serverHardwareUri) {
       output += '\t\u2022 Server Hardware: ' + getDeviceName(this.serverHardwareUri) + '\n';

diff --git a/src/test/resource.js b/src/test/resource.js
@@ -55,7 +55,7 @@ describe('Resource', () => {
     myKeys[6].should.equal('pxeBootPolicy');
   });
 
-  it('camelCaseToTitleCase undefined', () => {
+  it('camelCaseToTitleCase empty', () => {
     let serverProfileResource = new Resource(oneViewResource);
     let myKeys = Object.keys(oneViewResource);
     serverProfileResource.camelCaseToTitleCase('').should.equal('');