Adding coverage for oneview.js (startup)

src/oneview.js

@@ -19,37 +19,35 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 */
-
 const nlp = require('./middleware/nlp-middleware').nlp;
 const ovListener = require('./listener/oneview');
 const ovClient = require('./oneview-sdk/ov-client');
 const ovBrain = require('./middleware/ov-brain');
 
 const BULLET = '\n\t\u2022 ';
 
-const main = (robot) => {
+const main = (robot, oneViewClient, lexer, oneViewListener) => {
   // load OneView configuration data from external file
   let oneviewConfig;
   try {
     const configuration = require('../oneview-configuration.json');
-    robot.logger.info('Applying configuration from json file.');
+    robot.logger.info('Applying configuration from oneview-configuration.json file.');
     oneviewConfig = configuration;
   } catch(err) {
-    robot.logger.error('Error reading OneView configuration file: ', err);
-    //throw new error
-    return;
+    robot.logger.error('Cannot read oneview-configuration.json configuration file: ', err);
+    throw new Error('Cannot read oneview-configuration.json file!');
   }
 
   robot.logger.info('Initializing NLP');
-  const lex = nlp(robot);
+  const lex = lexer || nlp(robot);
 
-  robot.logger.info('Initializing OneView');
-  const client = new ovClient(oneviewConfig, robot);
+  robot.logger.info('Initializing OneView client');
+  const client = oneViewClient || new ovClient(oneviewConfig, robot);
 
   client.login(false).then(() => {
     robot.logger.info('Logged into OneView.');
     const brain = new ovBrain(client, robot, lex);
-    ovListener(robot, client, brain);
+    oneViewListener || ovListener(robot, client, brain);
     introBot();
   }).catch((err) => {
     robot.logger.error(err);
@@ -58,31 +56,30 @@ const main = (robot) => {
   function introBot() {
     client.ServerHardware.getAllServerHardware().then((sh) => {
       client.ServerProfiles.getAllServerProfiles().then((sp) => {
-        client.ServerProfileTemplates.getAllServerProfileTemplates()
-          .then((spt) => {
-            let room = '#' + client.chatRoom;
+        client.ServerProfileTemplates.getAllServerProfileTemplates().then((spt) => {
 
-            if (robot.adapterName === 'flowdock') {
-              room = client.chatRoom;
-            }
+          let room = '#' + client.chatRoom;
+          if (robot.adapterName === 'flowdock') {
+            room = client.chatRoom;
+          }
 
-            robot.messageRoom(room,
-              "Hello, I'm " + robot.name + "! "
-              +"Your OneView instance is currently showing:"
-              + BULLET + sh.members.length + " server(s)."
-              + BULLET + sp.members.length + " server profile(s)."
-              + BULLET + spt.members.length +" server profile template(s)."
-              + "\nHow can I assist you? Type '@" + robot.name
-              + " help' to learn what I can do.");
+          robot.messageRoom(room,
+            "Hello, I'm " + robot.name + "! "
+            +"Your OneView instance is currently showing:"
+            + BULLET + sh.members.length + " server(s)."
+            + BULLET + sp.members.length + " server profile(s)."
+            + BULLET + spt.members.length +" server profile template(s)."
+            + "\nHow can I assist you? Type '@" + robot.name
+            + " help' to learn what I can do.");
           });
       });
     });
   }
 
-  //TODO: Bug #22 Not working.  Need to perform an aysnc shutdown from the SCMB
+  // TODO: Bug #22 Not working.  Need to perform an aysnc shutdown from the SCMB
   function exitHandler() {
     robot.logger.debug('in exitHandler, calling disconnect');
-    client.Notifications.disconnect();
+    // client.Notifications.disconnect();
   }
 
   process.on('exit', exitHandler.bind(null, {

test/listener/utils/resource-transforms.js

@@ -0,0 +1,166 @@
+/*
+(c) Copyright 2016-2017 Hewlett Packard Enterprise Development LP
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+const ResourceTransforms = require('../../../src/listener/utils/resource-transforms');
+const OneViewBrain = require('../../../src/middleware/ov-brain');
+const OVClient = require('../../../src/oneview-sdk/ov-client');
+
+const sinon = require('sinon');
+const chai = require('chai');
+
+chai.should();
+const assert = chai.assert;
+
+describe('ResourceTransforms', () => {
+
+  const robot = {
+    name: 'bot',
+    adapterName: 'shell',
+    receive: function () {},
+    on: function () {},
+    listen: function () {},
+    respond: function () {},
+    messageRoom: function () {},
+    listenerMiddleware: function() {},
+    logger: {debug: function () {}, error: function () {}, info: function () {}}
+  };
+
+  const oneviewConfig = {
+    hosts: []
+  };
+  const oVClient = new OVClient(oneviewConfig, robot);
+  const brain = new OneViewBrain(oVClient, robot, {});
+
+  afterEach(() => {
+    robot.adapterName = 'shell';
+  });
+
+  it('slack', () => {
+    robot.adapterName = 'slack';
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let text = 'Hello\nWorld!';
+    let result = resourceTransforms.list(text);
+    '  \u2022 Hello.\n  \u2022 World!.'.should.equal(result);
+  });
+
+  it('hipchat', () => {
+    robot.adapterName = 'hipchat';
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let text = 'Hello\nWorld!';
+    let result = resourceTransforms.list(text);
+    '  - Hello.\n  - World!.'.should.equal(result);
+  });
+
+  it('list', () => {
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let text = 'Hello\nWorld!';
+    let result = resourceTransforms.list(text);
+    '  - Hello.\n  - World!.'.should.equal(result);
+  });
+
+  it('messageRoom', () => {
+    let spy = sinon.spy(robot, "messageRoom");
+
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let text = 'Hello World!';
+    resourceTransforms.messageRoom('slack-channel', {}, text);
+
+    assert(robot.messageRoom.callCount === 2);
+    ['slack-channel', 'Hello World!.'].should.deep.equal(robot.messageRoom.args[0]);
+    ['slack-channel', '{}'].should.deep.equal(robot.messageRoom.args[1])
+
+    spy.restore();
+  });
+
+  it('messageRoom resource', () => {
+    let spy = sinon.spy(robot, "messageRoom");
+
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let text = 'Hello World!';
+    resourceTransforms.messageRoom('slack-channel', 'resource', text);
+
+    assert(robot.messageRoom.callCount === 1);
+    ['slack-channel', 'resource.'].should.deep.equal(robot.messageRoom.args[0]);
+
+    spy.restore();
+  });
+
+  it('makePlural server profile', () => {
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let word = 'server profile';
+    let result = resourceTransforms.makePlural(1 , word);
+    '1 server profile'.should.equal(result);
+  });
+
+  it('makePlural server hardware', () => {
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let word = 'server hardware';
+    let result = resourceTransforms.makePlural(2 , word);
+    '2 server hardwares'.should.equal(result);
+  });
+
+  it('makePlural vowel', () => {
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let word = 'power delivery';
+    let result = resourceTransforms.makePlural(2 , word);
+    '2 power deliveries'.should.equal(result);
+  });
+
+  it('makePlural no count', () => {
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let word = 'server profile';
+    let result = resourceTransforms.makePlural(0 , word);
+    'no server profiles'.should.equal(result);
+  });
+
+  it('isAre 1', () => {
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let word = 'server profile';
+    let result = resourceTransforms.isAre(1 , word);
+    'is 1 server profile'.should.equal(result);
+  });
+
+  it('isAre 2', () => {
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+    let word = 'server profile';
+    let result = resourceTransforms.isAre(2 , word);
+    'are 2 server profiles'.should.equal(result);
+  });
+
+  it('error', () => {
+    let resourceTransforms = new ResourceTransforms(robot, brain);
+
+    let msg = {
+      robot: {},
+      message: {TextMessage: {user: '', text: '@bot show last fiv alerts.'}},
+      count: 1,
+      send: function () {}
+    };
+    let spy = sinon.spy(msg, "send");
+    let error = {};
+
+    resourceTransforms.error(msg, error);
+
+    assert(msg.send.callCount === 1);
+    spy.restore();
+  });
+
+});