Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pagination in chat #132

Merged
merged 4 commits into from
Nov 6, 2017
Merged

Support pagination in chat #132

merged 4 commits into from
Nov 6, 2017

Conversation

llvieira
Copy link
Member

@llvieira llvieira commented Nov 4, 2017

Closes #2.

  • Recursive algorithm to paging things out of an array.
  • Now, when someone says list all, the messages will be separated into parts of 10.

@llvieira llvieira changed the title Support to pagination in chat Support pagination in chat Nov 4, 2017
danielreed
danielreed reviewed Nov 6, 2017
View reviewed changes
src/listener/base-listener.js
this.makePagination(jump + paginationJump, members, msg, response);
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this code! It would be great if we could add some tests for this in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! yes, I'll do that.

@danielreed danielreed merged commit b607978 into master Nov 6, 2017
@danielreed danielreed deleted the support_pagination branch August 16, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielreed danielreed danielreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@llvieira @danielreed