Issue: #88 Fix compliance on unassigned profile fails #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielreed
requested changes
Nov 14, 2017
| @@ -9,7 +9,7 @@ copies of the Software, and to permit persons to whom the Software is | |||
| furnished to do so, subject to the following conditions: | |||
|
|
|||
| The above copyright notice and this permission notice shall be included in | |||
| all copies or substantial portions of the Software. | |||
| all copies or substMakeProfileCompliantantial portions of the Software. | |||
There was a problem hiding this comment.
You'll have to fix this. We can't modify the license text in any of the files.
| members: [profileResponse] | ||
| }; | ||
|
|
||
| let listeners = []; |
|
|
||
| assert(serverProfileTemplateListener.PowerOffHardware.callCount === 0); | ||
| assert(serverProfilesListener.MakeServerProfileCompliant.callCount === 1); | ||
| //console.log(serverProfilesListener.MakeServerProfileCompliant); |
| assert(sp1.calledOnce); | ||
|
|
||
| sp1.restore(); | ||
|
|
There was a problem hiding this comment.
probably want to call restore on st1 and st2
There was a problem hiding this comment.
I tried to. It threw an exception
- Fix minor changes.
danielreed
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.