-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted camelCase field names to title case. #66
Conversation
return camelCase; | ||
} | ||
camelCase = camelCase.trim(); | ||
var newText = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of var use let
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
newText = camelCase[0].toUpperCase(); | ||
} | ||
|
||
for (var i = 1; i < camelCase.length; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use let
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -43,8 +43,11 @@ export default class ServerHardware extends Resource { | |||
if (this.__isNonDisplayField__(field) || !this[field]) { | |||
continue; | |||
} | |||
|
|||
var displayField = this.camelCaseToTitleCase(field); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use let
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use let instead of var.
For issue HewlettPackard#58 Patch HewlettPackard#2: Made changes for ES6.
@@ -38,8 +38,11 @@ export default class ServerProfileTemplate extends Resource { | |||
if (this.__isNonDisplayField__(field) || !this[field]) { | |||
continue; | |||
} | |||
|
|||
let displayField = this.amelCaseToTitleCase(field); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be camelCaseToTitleCase I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this PR now and you can follow up with a new one to fix this issue.
For issue #58