Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when running make test target locally #61

Closed
sfc-gh-eraigosa opened this issue Jul 9, 2016 · 0 comments
Closed

Issues when running make test target locally #61

sfc-gh-eraigosa opened this issue Jul 9, 2016 · 0 comments

Comments

@sfc-gh-eraigosa
Copy link
Member

We should make the local desktop testing for this project easier. Currently we have to make with the following command locally, unless you clone the project perfectly:

USE_CONTAINER=true GH_USER=HewlettPackard GH_REPO=oneview-golang make test

Lets make using docker to build this project the default, so that requirements will now be:

  • docker
  • make

No need to have golang even installed. This should remove the requirement for USE_CONTAINER option, but we should still have the option so that the setting USE_CONTAINER=false is possible under travis builds, where we don't have docker.

If we always build in docker then we can assume that GH_USER can always be HewlettPackard and GH_REPO=oneview-golang can always be oneview-golang. This also improves local testing before submits.

Lets also fix how we call docker to include -e GH_REPO and -e GH_USER in the Makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant