Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIG Improvements for API300 #141

Closed
jsmartt opened this issue Jan 26, 2017 · 0 comments
Closed

LIG Improvements for API300 #141

jsmartt opened this issue Jan 26, 2017 · 0 comments

Comments

@jsmartt
Copy link
Collaborator

jsmartt commented Jan 26, 2017

Scenario/Intent

I have a couple of issues with the LIG resource for API300 Synergy:

  1. The Default value of the enclosure_index in #add_interconnect (seen here) is always 1, but according to the API docs...

    The enclosureIndex specifies the enclosure number that this interconnect map entry template applies to within the logical interconnect group. In a single enclosure logical interconnect group this will be 1, except for Virtual Connect SE 16Gb FC Module which will be -1. The -1 is used to indicate that such a logical interconnect group, and the interconnect map entry template, can be applied to more than one enclosure within the same enclosure group.

    I propose we build that logic into the SDK (API300 Synergy and C7000); it's a simple if statement.

  2. In API version 200, the LIG interconnect enclosure relativeValue seemed to only support the value 1, so we hardcoded it in here (and it's in the Synergy resource here too), but according to the 300 Synergy docs, it can be -1 or 1 to 5. This is currently causing me issues because it was set to -1 on the GUI, and when I try to update it, the SDK sets it to 1, but this isn't a value that can be updated. Because of this default value we also can't specify interconnects for multiple enclosures with the same bay number (see this)

    I propose that we add a parameter to add_interconnect and parse_interconnect_map_template allowing it to be configurable (only needed on Synergy, not C7000). We also need to fix the logic in this block to support interconnects for multiple enclosures with the same bay number.

  3. There is no default for the redundancyType attribute, which is required. It defaults to Redundant in the GUI, so I think we should default it to that in the SDK too (all API versions and variants?).

Environment Details

  • OneView SDK Version: 3.1.0
  • OneView Appliance Version: 300
  • OneView Client API Version: 300
@jsmartt jsmartt changed the title LIG interconnect enclosure relativeValue hardcoded to 1 LIG interconnect enclosureIndex and enclosure relativeValue aren't configurable Jan 26, 2017
@jsmartt jsmartt changed the title LIG interconnect enclosureIndex and enclosure relativeValue aren't configurable LIG Improvements for API300 Jan 26, 2017
@jsmartt jsmartt self-assigned this Jan 27, 2017
jsmartt added a commit that referenced this issue Jan 27, 2017
#141 Fixed Synergy LIG #add_interconnect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant