Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#141 Fixed Synergy LIG #add_interconnect #143

Merged
merged 2 commits into from
Jan 27, 2017
Merged

#141 Fixed Synergy LIG #add_interconnect #143

merged 2 commits into from
Jan 27, 2017

Conversation

jsmartt
Copy link
Collaborator

@jsmartt jsmartt commented Jan 27, 2017

Description

See the linked issue for more context and description, but here's the short of it:

  1. In #add_interconnect for Synergy LIG, set the correct default enclosureIndex based on the interconnect type
  2. In #add_interconnect, for Synergy LIG, set the relativeValue of the enclosure to the given enclosure_index value. This is necessary for LIGs with multiple enclosures
  3. In #initialize, for Synergy LIG, set the default redundancyType value (required) to Redundant, like the GUI.

Issues Resolved

Fixes #141

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

@jsmartt
Copy link
Collaborator Author

jsmartt commented Jan 27, 2017

Oops. This will conflict with #140 . I didn't see that PR, so made a few of the same changes. I'll get rid of those real quick...

Copy link
Contributor

@tmiotto tmiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me 👍

@jsmartt jsmartt merged commit c9518f1 into master Jan 27, 2017
@jsmartt jsmartt deleted the lig_fixes branch January 27, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants