Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in integration test for Build Plan #175

Merged
merged 8 commits into from
Feb 22, 2017

Conversation

aalexmonteiro
Copy link
Contributor

@aalexmonteiro aalexmonteiro commented Feb 14, 2017

Description

The integration test for the build plan was not possible to test the appliance error. After reimaging the appliance, the test was performed and errors were found due to object search that did not exist.

Issues Resolved

#174

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

@tmiotto
Copy link
Contributor

tmiotto commented Feb 17, 2017

@aalexmonteiro don't you think this attribute missing in the integration test shouldn't be also highlighted on the examples ?

@aalexmonteiro
Copy link
Contributor Author

aalexmonteiro commented Feb 17, 2017

@tmiotto , you're right. Good hint. :)

@aalexmonteiro
Copy link
Contributor Author

@tmiotto , I added the example with custom attributes.


options = {
name: 'Build_Plan_1',
oeBuildPlanType: 'Deploy'
}

plan_script = OneviewSDK::ImageStreamer::API300::PlanScript.find_by(@client, name: @plan_script_name).first
plan_script = OneviewSDK::ImageStreamer::API300::PlanScript.find_by(@client, name: @plan_script1_name).first
plan_script2 = OneviewSDK::ImageStreamer::API300::PlanScript.find_by(@client, name: @plan_script2_name).first
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the _client_i3s.rb.example file with these new names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsmartt , changes made.

Copy link
Collaborator

@jsmartt jsmartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me

@aalexmonteiro aalexmonteiro merged commit 90e668c into master Feb 22, 2017
@aalexmonteiro aalexmonteiro deleted the bugfix/174-delete_test_build_plan branch February 22, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants