Move search() into the base class ORapi #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On reflection I think the basic idea is sound but it's architecturally incorrect to put OpsRamp-specific code into the ApiWrapper class. That and ApiObject form a base layer that is applicable to any REST api and it would be wrong to break that. Instead, I will look at introducing an intermediate base class called something like ORapi derived from ApiWrapper, move search into that class, and make the others subclasses of ORapi instead of directly from ApiWrapper. |
Many classes have their own "search" functions but most of them are identical so it makes sense to move into the base class and override the minority that need to behave differently. Change the unit tests to accommodate that, but also refactor some of them to avoid reusing the requests_mock object because that can hide issues where a test is succeeding only because a previous one has primed the mock for it.
jofegan
force-pushed
the
refactor-search-functions
branch
from
0a5540d
to
b351e5e
Compare
jofegan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many classes have their own "search" functions but most of them are
identical so it makes sense to move into the base class and override
the minority that need to behave differently.
Change the unit tests to accommodate that, but also refactor some of
them to avoid reusing the requests_mock object because that can hide
issues where a test is succeeding only because a previous one has
primed the mock for it.