Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move search() into the base class ORapi #90

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Move search() into the base class ORapi #90

merged 1 commit into from
Nov 14, 2020

Commits on Nov 14, 2020

  1. Move search() into the base class ORapi 

    Many classes have their own "search" functions but most of them are
identical so it makes sense to move into the base class and override
the minority that need to behave differently.

Change the unit tests to accommodate that, but also refactor some of
them to avoid reusing the requests_mock object because that can hide
issues where a test is succeeding only because a previous one has
primed the mock for it.
    @jofegan
    jofegan committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    b351e5e View commit details
    Browse the repository at this point in the history