Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a few patches to poppler #2

Merged
merged 6 commits into from
Feb 28, 2020
Merged

Adding a few patches to poppler #2

merged 6 commits into from
Feb 28, 2020

Conversation

cjordan7
Copy link
Contributor

No description provided.

@hazimeh
Copy link
Member

hazimeh commented Feb 27, 2020

A quick look at B203, I think the condition is wrong. The original bug was triggered when fileSpec is not a Dict but it was used as a Dict when calculating the value of obj1.

The proper forward-porting would be to reverse the fix and add a canary just before obj1 = fileSpec.dictLookup("Desc");. The trigger condition would be: fileSpec.isDict() == false (or the equivalent using the logical negation operator: !)

Then, when fileSpec is not a Dict, the bug is recorded as triggered (by the canary), and the following line would try to use it as Dict, which is a Type Confusion bug (please change the type accordingly in the Google Sheets document).

@cjordan7 cjordan7 changed the title Adding 4 patches-bugs to poppler Adding a few patches to poppler Feb 27, 2020
@cjordan7
Copy link
Contributor Author

Yeah you are right. I have updated the Google Sheets document and the patch as well. I have even added 2 more patches.

There is no need to remove the definition of the dummy XRef object since it does not pertain to the bug itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants