Added 9 patches to openssl #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix ensures that the length comparison is done through subtraction instead of addition, so even if the addition overflows, the bug would not manifest. Hence, the canary should only execute if the fix is not applied.
hazimeh
reviewed
Feb 28, 2020
| if (i != 0) { | ||
| + | ||
| +#ifdef MAGMA_ENABLE_CANARIES | ||
| + MAGMA_LOG(101,INT_MAX - inl < i); |
There was a problem hiding this comment.
Move this bug to a "graveyard" folder instead of "bugs".
The original bug report states that no internal instance of the function call can trigger this bug.
Although it could possibly be triggered by someone calling the function directly, we're not interested in that right now.
So instead of deleting it, I suggest moving it to a graveyard directory in case it comes into use later.
hazimeh
reviewed
Feb 28, 2020
| +#else | ||
| + int magma_int = rsa_pss_to_ctx(ctx, NULL, sigalg, pkey); | ||
| +#ifdef MAGMA_ENABLE_CANARIES | ||
| + MAGMA_LOG(108, magma_int < 0); |
There was a problem hiding this comment.
Please add an entry for this bug in the spreadsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.