Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#62] Fix urls, toggler #86

Merged
merged 1 commit into from
May 17, 2022
Merged

[#62] Fix urls, toggler #86

merged 1 commit into from
May 17, 2022

Conversation

elisad5791
Copy link
Contributor

Сделала перенос урлов и переставила гамбургер влево.

@fey fey requested a review from amshkv May 13, 2022 12:06
@elisad5791
Copy link
Contributor Author

Посмотреть можно здесь
деплой на netlify

@fey
Copy link
Collaborator

fey commented May 16, 2022

@elisad5791 здесь нужно немного подождать, попрошу ребят посмотреть

amshkv
amshkv approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@amshkv amshkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

у меня только один вопрос - зачем :)
урлы наверное лучше починить точечно, применив класс к ссылкам конкретным, а не ко всей странице сразу

@fey
Copy link
Collaborator

fey commented May 17, 2022

@amshkv на мобиле бургер не работает

@amshkv
Copy link
Contributor

amshkv commented May 17, 2022

ага, из-за надписи про форк, окс

@fey fey merged commit 80d44ca into Hexlet:main May 17, 2022
@elisad5791 elisad5791 deleted the mobile-fix branch May 17, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amshkv amshkv amshkv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elisad5791 @fey @amshkv