This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Add eslint. (Closes #44) #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jougene
reviewed
Oct 3, 2019
Makefile.local
Outdated
| @@ -0,0 +1,36 @@ | |||
| test: | |||
There was a problem hiding this comment.
А почему новый файл?
Что не так было со старым?
There was a problem hiding this comment.
По ошибке попал. Сейчас уберу.
|
По поводу линтера. У меня было два варианта:
В итоге я остановился на первом варианте, форматирование prettier мне нравится, и оно уже использовалось у нас. Так же ошибки в форматирование по правилам prettier теперь проверяются при линте. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Болезненый PR конечно, но это один раз.