-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement:more feature for hz-network #59
Conversation
Co-authored-by: AC0xRPFS001 <73421607+kyometori@users.noreply.github.com>
… support maxium of 256 characters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 你後面的 commit 把你前面被我 request changes 的東西又蓋回去了
- 你可以解釋一下你寫的 code 大致上的行為嗎(做了什麼、演算法),還有我有以下的疑慮:
- 回覆的 fetch message 會不會導致 api spam
- 我看到他是找前 20 則,那如果回覆的訊息太過前面(e.g. 250 則),會發生什麼事?
Co-authored-by: AC0xRPFS001 <73421607+kyometori@users.noreply.github.com>
1.fixed |
code 我目前看是沒什麼問題。不過我好奇為什麼改成使用 embed 顯示回覆,而不是使用舊版回覆的格式,這樣有什麼優點嗎。 另外如果 fetch 的各頻道中回覆的 message,有沒有辦法直接使用 reply? 然後 @Zollo757347 你要看看嗎 喔還有我看不太懂加那個 u200b 是在幹嘛,可以補充一下嗎 |
1.embed有頭貼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
剩下該問的都在 Discord 上問完了,從以下訊息開始:
https://discord.com/channels/572733182412193792/572733182412193794/1190480650587885578
Sticker support for hz-network
Reply url for hz-network