Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement:more feature for hz-network #59

Merged
merged 11 commits into from
Dec 30, 2023
Merged

Conversation

cutebear0123
Copy link
Contributor

@cutebear0123 cutebear0123 commented Dec 22, 2023

Sticker support for hz-network
Reply url for hz-network

src/classes/HZNetwork.ts Outdated Show resolved Hide resolved
src/classes/HZNetwork.ts Outdated Show resolved Hide resolved
@kyometori kyometori added the enhancement New feature or request label Dec 22, 2023
cutebear0123 and others added 3 commits December 22, 2023 20:18
Co-authored-by: AC0xRPFS001 <73421607+kyometori@users.noreply.github.com>
@cutebear0123 cutebear0123 changed the title feature:sticker support for hz-network enhancement:more feature for hz-network Dec 22, 2023
@kyometori kyometori self-requested a review December 24, 2023 12:13
kyometori
kyometori previously approved these changes Dec 24, 2023
Copy link
Member

@kyometori kyometori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 你後面的 commit 把你前面被我 request changes 的東西又蓋回去了
  2. 你可以解釋一下你寫的 code 大致上的行為嗎(做了什麼、演算法),還有我有以下的疑慮:
  3. 回覆的 fetch message 會不會導致 api spam
  4. 我看到他是找前 20 則,那如果回覆的訊息太過前面(e.g. 250 則),會發生什麼事?

src/classes/HZNetwork.ts Outdated Show resolved Hide resolved
src/classes/HZNetwork.ts Outdated Show resolved Hide resolved
cutebear0123 and others added 2 commits December 27, 2023 19:29
Co-authored-by: AC0xRPFS001 <73421607+kyometori@users.noreply.github.com>
@cutebear0123
Copy link
Contributor Author

  1. 你後面的 commit 把你前面被我 request changes 的東西又蓋回去了
  2. 你可以解釋一下你寫的 code 大致上的行為嗎(做了什麼、演算法),還有我有以下的疑慮:
  3. 回覆的 fetch message 會不會導致 api spam
  4. 我看到他是找前 20 則,那如果回覆的訊息太過前面(e.g. 250 則),會發生什麼事?

1.fixed
2.每次reply去每個頻道fetch前20個訊息
如果有同樣內容和發送人就放連結
然後發送的時候為了避免重複訊息,如果有重複會在後面加上u+200b
2.1.我測試66不會
2.2.沒有連結

@kyometori
Copy link
Member

kyometori commented Dec 30, 2023

code 我目前看是沒什麼問題。不過我好奇為什麼改成使用 embed 顯示回覆,而不是使用舊版回覆的格式,這樣有什麼優點嗎。

另外如果 fetch 的各頻道中回覆的 message,有沒有辦法直接使用 reply?

然後 @Zollo757347 你要看看嗎

喔還有我看不太懂加那個 u200b 是在幹嘛,可以補充一下嗎

@cutebear0123
Copy link
Contributor Author

code 我目前看是沒什麼問題。不過我好奇為什麼改成使用 embed 顯示回覆,而不是使用舊版回覆的格式,這樣有什麼優點嗎。

另外如果 fetch 的各頻道中回覆的 message,有沒有辦法直接使用 reply?

然後 @Zollo757347 你要看看嗎

1.embed有頭貼
2.webhook沒有reply

Copy link
Member

@kyometori kyometori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

剩下該問的都在 Discord 上問完了,從以下訊息開始:
https://discord.com/channels/572733182412193792/572733182412193794/1190480650587885578

@Zollo757347 Zollo757347 merged commit 7874c29 into HiZollo:dev Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants