Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin CI dependencies #201

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Pin CI dependencies #201

merged 3 commits into from
Dec 21, 2023

Conversation

hf-sheese
Copy link
Contributor

To pin the CI dependencies, I added a dev_requirements folder to kohlrabi.

Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt für mich. Danke 👍
Bitte entferne jetzt abschließend noch die ungepinnten dependencies aus der tox.ini. die brauchen wir ja nicht mehr, weil sie jetzt in der .in-datei (ungepinnt) und .txt-datei (gepinned) liegen

mypy
types-requests
networkx-stubs
pytest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

das war schon vorher so, man könnte aber auch die type_check-umgebung von der test-umgebung "erben" lassen. keine ahnung ob das sinnvoll wäre oder die sache nur komplizierter macht

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also kein todo für diesen PR!

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@hf-kklein hf-kklein linked an issue Dec 21, 2023 that may be closed by this pull request
@hf-sheese hf-sheese enabled auto-merge (squash) December 21, 2023 09:44
@hf-sheese hf-sheese merged commit 4e03cbd into main Dec 21, 2023
7 checks passed
@hf-sheese hf-sheese deleted the Add-dev_requirements branch December 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin CI Dependencies
2 participants