-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin CI dependencies #201
Pin CI dependencies #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passt für mich. Danke 👍
Bitte entferne jetzt abschließend noch die ungepinnten dependencies aus der tox.ini. die brauchen wir ja nicht mehr, weil sie jetzt in der .in-datei (ungepinnt) und .txt-datei (gepinned) liegen
mypy | ||
types-requests | ||
networkx-stubs | ||
pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
das war schon vorher so, man könnte aber auch die type_check-umgebung von der test-umgebung "erben" lassen. keine ahnung ob das sinnvoll wäre oder die sache nur komplizierter macht
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also kein todo für diesen PR!
To pin the CI dependencies, I added a dev_requirements folder to kohlrabi.