Log to file #46
Merged
Log to file #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much, I should have done this ages ago. |
twspace_dl/__main__.py:146: error: Argument "handlers" to "basicConfig" has incompatible type "List[object]"; expected "Optional[Iterable[Handler]]"
|
Is this done or do you want to work on it more? |
|
SonarCloud Quality Gate failed.
|
|
Modifying logging's handler violates SonarCloud rules. Is there another workaround to log output of logging to file? I don't come up with. |
|
I am ready for merge. Please merge if you ok. |
It's fine, it just tells me to check for no injection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2
When executing
twspace_dl -i <url>with-lor--log, log file (.twspace-dl.%Y-%m-%d_%H-%M-%S_%s.log) will be created in pwd.