Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve smv_released_pattern section #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

problame
Copy link

@problame problame commented Sep 8, 2023

  1. It says Everything except master branch, so, it should include tags.
  2. The colon in the negative regex match was probably a typo, as it prevents matching of the master branch. With that colon, none of the refs in my repo match and hence all refs are treated as not-released.
  3. The example sed-s away the refs/ prefix, but, it seems like smv_released_pattern is evaluated against the full refspec, i.e., with refs/. Avoid the confusion, or, fix the docs, respectively.

fixes #66

1. It says `Everything except master branch`, so, it should include tags.
2. The colon in the negative regex match was probably a typo, as it prevents matching of the `master` branch. With that colon, none of the refs in my repo match and hence all refs are treated as not-released.
@problame problame changed the title docs: configuration: fix smv_released_pattern docs: improve smv_released_pattern section Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'smv_released_pattern' examples should start with 'refs/'
1 participant