Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureFactory AddNumberInputField and AddTextInputField hintText parameter #255

Open
BernoldNL opened this issue Feb 4, 2022 · 1 comment
Labels
Bug A problem which impairs or prevents the functions of the product HS Core This issue involves changes to core HS systems. NOT FOR PLUGINS Jira This issue has been linked to a Jira issue

Comments

@BernoldNL
Copy link

Environment and System Config

  • OS: Windows
  • Language: C#
  • IDE: VS2019
  • HomeSeer Version: v4.2.7.0
  • PluginSDK Version: [v1.3.1.0]

Describe the issue
The hintText parameter is documented as "The text displayed to the user to help them know what kind of value to input." But instead of a hint text, it acts like targetStatus (as in Addbutton) or a label (as in StatusGraphic): It ends up as Single Value Status Label. There is no hint text near the input on the Devices Page.

Device Settings page, Status/Graphics tab:
afbeelding

Device page:
afbeelding

Steps to Reproduce

Steps to reproduce the behavior:
            DeviceFactory deviceFactory = DeviceFactory.CreateDevice(Id);
            deviceFactory.WithName("Device name");
            NewDeviceData newDeviceData = deviceFactory.PrepareForHs();
            int deviceRefId = HomeSeerSystem.CreateDevice(newDeviceData);
            if (deviceRefId > 0)
            {
                FeatureFactory featureFactory = FeatureFactory.CreateFeature(Id);
                featureFactory.OnDevice(deviceRefId);
                featureFactory.WithName("Feature name");
                featureFactory.AddNumberInputField(50, "Hint: 10-90 only!");
                featureFactory.AddNumberInputField(100, "Hint: 0-10 only!");
                featureFactory.AddTextInputField(200, "Type here");
                NewFeatureData newFeatureData = featureFactory.PrepareForHs();
                int featureRef = HomeSeerSystem.CreateFeatureForDevice(newFeatureData);
            }

Expected behavior
afbeelding

Screenshots
See above.

Logs
N/A

Additional info
hintText can't currently be left empty, or start with a space. If the feature only has 1 input and the feature name is clear, a hint is not really needed.

And hints should probably be kept short to fit the input (unless they go under the input).

@spudwebb
Copy link
Collaborator

spudwebb commented Feb 4, 2022

Tracked as HS-1566. Thanks for reporting

@spudwebb spudwebb added Bug A problem which impairs or prevents the functions of the product HS Core This issue involves changes to core HS systems. NOT FOR PLUGINS Jira This issue has been linked to a Jira issue and removed Feedback labels Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A problem which impairs or prevents the functions of the product HS Core This issue involves changes to core HS systems. NOT FOR PLUGINS Jira This issue has been linked to a Jira issue
Projects
None yet
Development

No branches or pull requests

2 participants