RemoveViewById was not removing views from viewList, only from viewIds #95 #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUI.View.ViewCollectionHelper.RemoveViewById was removing the viewId, but then iterating through the whole viewList and keeping them all. This caused elements to not disappear from the UI.
Fixed by tracking the index of the removed item and making sure the new viewList didn't include that item and that subsequent views had a decremented index in viewId.
Closes #95