Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup-homebrew: handle stable on stable Docker images #538

Merged
merged 1 commit into from
May 17, 2024
Merged

setup-homebrew: handle stable on stable Docker images #538

merged 1 commit into from
May 17, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented May 17, 2024

  • Don't assume origin/HEAD exists
  • Don't checkout master first for stable - we don't support downgrades.

@Bo98 Bo98 force-pushed the setup-homebrew-stable-fix branch 2 times, most recently from 4947b51 to b7d58b4 Compare May 17, 2024 15:04
MikeMcQuaid
MikeMcQuaid approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @Bo98!

@Bo98 Bo98 force-pushed the setup-homebrew-stable-fix branch from b7d58b4 to e05416b Compare May 17, 2024 15:08
@Bo98 Bo98 merged commit 677db44 into master May 17, 2024
7 checks passed
@Bo98 Bo98 deleted the setup-homebrew-stable-fix branch May 17, 2024 15:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bo98 @MikeMcQuaid