Merge pull request #5137 from amancevice/fix-deprecated-s3-download-s…

…trategy

Fix to deprecated S3DownloadStrategy

Library/Homebrew/compat/download_strategy.rb

@@ -26,6 +26,13 @@ def _fetch(url:, resolved_url:)
     ENV["AWS_ACCESS_KEY_ID"] = ENV["HOMEBREW_AWS_ACCESS_KEY_ID"]
     ENV["AWS_SECRET_ACCESS_KEY"] = ENV["HOMEBREW_AWS_SECRET_ACCESS_KEY"]
 
+    begin
+      require "aws-sdk-s3"
+    rescue LoadError
+      Homebrew.install_gem! "aws-sdk-s3", "~> 1.8"
+      require "aws-sdk-s3"
+    end
+
     begin
       signer = Aws::S3::Presigner.new
       s3url = signer.presigned_url :get_object, bucket: bucket, key: key
@@ -204,12 +211,6 @@ def scp_source
 class DownloadStrategyDetector
   class << self
     module Compat
-      def detect(url, using = nil)
-        strategy = super
-        require_aws_sdk if strategy == S3DownloadStrategy
-        strategy
-      end
-
       def detect_from_url(url)
         case url
         when %r{^s3://}