Fix to deprecated S3DownloadStrategy

[amancevice]

Remove references to removed require_aws_sdk method
See commit: 599ecc9b5ad7951b8ddc51490ebe93a976d43b29

I couldn't find any documentation on what exactly users are supposed to do with the warning:

Calling S3DownloadStrategy is deprecated! Use maintaining S3DownloadStrategy in your own formula or tap instead.

Is there documentation on this?

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[reitermarkus]

Was the require_aws_sdk method removed?

[amancevice]

Yeah, it looks like it got taken out during deprecation. I linked the commit in the PR description but here again for reference
599ecc9

[MikeMcQuaid]

@amancevice My bad, could you re-add that method into this Compat module instead?

[MikeMcQuaid]

@amancevice Actually if this is working for you it's fine as-is.

[MikeMcQuaid]

Use maintaining S3DownloadStrategy in your own formula or tap instead.

Whoops, this wording isn't ideal, updating in #5138.

I couldn't find any documentation on what exactly users are supposed to do with the warning:
Is there documentation on this?

Hopefully the new messaging in #5138 is a bit clearer. In short, you're meant to move this code into your formula (or tap if you use require_relative) as Homebrew is not going to maintain it any more.

I apologise that this is a relatively recent 180; ideally we'd have done this before accepting these download strategies but I think it's better for everyone if Homebrew isn't maintaining download strategies we don't actually use.

[MikeMcQuaid]

Thanks again @amancevice!