Merge pull request #16155 from mahrud/quickfix/allow-branch-urls

audit(github): also permit refs/heads in GitHub URLs
Homebrew · Oct 28, 2023 · 700c7de · 700c7de
2 parents 97eda64 + eebffa8
commit 700c7de
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Library/Homebrew/rubocops/urls.rb b/Library/Homebrew/rubocops/urls.rb
@@ -217,11 +217,11 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node)
             problem "Use /archive/ URLs for GitHub tarballs (url is #{url})."
           end
 
-          archive_ref_tags_gh_pattern = %r{https://.*github.*/archive/(?![a-fA-F0-9]{40})(?!refs/tags/).*\.tar\.gz$}
-          audit_urls(urls, archive_ref_tags_gh_pattern) do |_, url|
+          archive_refs_gh_pattern = %r{https://.*github.+/archive/(?![a-fA-F0-9]{40})(?!refs/(tags|heads)/)(.*)\.tar\.gz$}
+          audit_urls(urls, archive_refs_gh_pattern) do |match, url|
             next if url.end_with?(".git")
 
-            problem "Use /archive/refs/tags URLs for GitHub tarballs (url is #{url})."
+            problem "Use refs/tags/#{match[2]} or refs/heads/#{match[2]} for GitHub references (url is #{url})."
           end
 
           # Don't use GitHub .zip files