Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit(github): also permit refs/heads in GitHub URLs #16155

Merged
merged 1 commit into from Oct 28, 2023

Conversation

mahrud
Copy link
Contributor

@mahrud mahrud commented Oct 28, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This fixes the issue mentioned in #16126 (comment).

I would have added an auto-corrector, but I don't think we can choose whether the user provided a tag reference or branch reference.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit 700c7de into Homebrew:master Oct 28, 2023
27 checks passed
@mahrud mahrud deleted the quickfix/allow-branch-urls branch October 28, 2023 22:34
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants