Merge pull request #16052 from Bo98/to_hash-perf

Improve performance of `Formula#to_hash`

Library/Homebrew/formula.rb

@@ -537,8 +537,7 @@ def oldname
   sig { returns(T::Array[String]) }
   def oldnames
     @oldnames ||= if tap
-      T.must(tap).formula_renames
-       .flat_map { |old_name, new_name| (new_name == name) ? old_name : [] }
+      T.must(tap).formula_oldnames.fetch(name, [])
     else
       []
     end
@@ -2237,7 +2236,7 @@ def to_hash
       "versions"                 => {
         "stable" => stable&.version&.to_s,
         "head"   => head&.version&.to_s,
-        "bottle" => !bottle_specification.checksums.empty?,
+        "bottle" => bottle_defined?,
       },
       "urls"                     => {},
       "revision"                 => revision,
@@ -2434,7 +2433,7 @@ def bottle_hash
       "files"    => {},
     }
     bottle_spec.collector.each_tag do |tag|
-      tag_spec = bottle_spec.collector.specification_for(tag)
+      tag_spec = bottle_spec.collector.specification_for(tag, no_older_versions: true)
       os_cellar = tag_spec.cellar
       os_cellar = os_cellar.inspect if os_cellar.is_a?(Symbol)
 

Library/Homebrew/tap.rb

@@ -767,6 +767,15 @@ def formula_renames
     end
   end
 
+  # Hash with tap formula old names. Reverse of {#formula_renames}.
+  sig { returns(T::Hash[String, T::Array[String]]) }
+  def formula_oldnames
+    @formula_oldnames ||= formula_renames.each_with_object({}) do |(old_name, new_name), hash|
+      hash[new_name] ||= []
+      hash[new_name] << old_name
+    end
+  end
+
   # Hash with tap migrations.
   sig { returns(Hash) }
   def tap_migrations

Library/Homebrew/utils/bottles.rb

@@ -209,10 +209,7 @@ def linux?
 
       sig { returns(T::Boolean) }
       def macos?
-        to_macos_version
-        true
-      rescue MacOSVersion::Error
-        false
+        MacOSVersion::SYMBOLS.key?(system)
       end
 
       sig { returns(T::Boolean) }