Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of Formula#to_hash #16052

Merged
merged 1 commit into from Sep 28, 2023
Merged

Improve performance of Formula#to_hash #16052

merged 1 commit into from Sep 28, 2023
+13 −8

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Sep 28, 2023

Removing time spent on file loading etc, this makes to_hash as much as twice as fast for me.

This in turn improves formula API generation speed.

@Bo98 Bo98 mentioned this pull request Sep 28, 2023
Merged
MikeMcQuaid
MikeMcQuaid approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit b5c3130 into Homebrew:master Sep 28, 2023
25 checks passed
@Bo98 Bo98 deleted the to_hash-perf branch September 28, 2023 13:49
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bo98 @MikeMcQuaid