Merge pull request #1673 from MikeMcQuaid/audit-fails-with-llvm

audit: flag use of "fails_with :llvm".
Homebrew · Dec 18, 2016 · e95c843 · e95c843
2 parents b87d27f + cf1fa0c
commit e95c843
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
@@ -1000,6 +1000,10 @@ def audit_line(line, _lineno)
       problem "Use Language::Node for npm install args"
     end
 
+    if line.include?("fails_with :llvm")
+      problem "'fails_with :llvm' is now a no-op so should be removed"
+    end
+
     return unless @strict
 
     if line =~ /system ((["'])[^"' ]*(?:\s[^"' ]*)+\2)/

diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb
@@ -2340,6 +2340,8 @@ def cxxstdlib_check(check_type)
     #   version '4.8.1'
     # end</pre>
     def fails_with(compiler, &block)
+      # TODO: deprecate this in future.
+      # odeprecated "fails_with :llvm" if compiler == :llvm
       specs.each { |spec| spec.fails_with(compiler, &block) }
     end
 

diff --git a/Library/Homebrew/software_spec.rb b/Library/Homebrew/software_spec.rb
@@ -173,6 +173,8 @@ def patch(strip = :p1, src = nil, &block)
   end
 
   def fails_with(compiler, &block)
+    # TODO: deprecate this in future.
+    # odeprecated "fails_with :llvm" if compiler == :llvm
     compiler_failures << CompilerFailure.create(compiler, &block)
   end