Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Stop using deprecated Actions params #14692

Closed
1 task done
issyl0 opened this issue Feb 17, 2023 · 2 comments · Fixed by #14695
Closed
1 task done

[CI] Stop using deprecated Actions params #14692

issyl0 opened this issue Feb 17, 2023 · 2 comments · Fixed by #14695
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age

Comments

@issyl0
Copy link
Member

issyl0 commented Feb 17, 2023

Verification

Provide a detailed description of the proposed feature

GitHub are deprecating set-output, save-state in favour of "Environment Files".

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

What is the motivation for the feature?

Reducing noise in the "Checks" view on a PR.

Screenshot 2023-02-17 at 16 32 19

How will the feature be relevant to at least 90% of Homebrew users?

It won't, but it'll reduce cognitive load for maintainers seeing these warnings.

What alternatives to the feature have been considered?

Leave them and let our Actions break in June 2023.

@issyl0 issyl0 added the features New features label Feb 17, 2023
@MikeMcQuaid MikeMcQuaid added the help wanted We want help addressing this label Feb 17, 2023
@Bo98
Copy link
Member

Bo98 commented Feb 17, 2023

Yeah was non-trivial work it turned out but I think most of the tricky stuff is dealt with. setup-homebrew is the big one and that's sorted. actions/cache@v3 can now be used but with care (it rarely errors if it's not working) - I can pick up that.

There's a couple of tasks in Homebrew/actions that needs sorting too.

Not sure if there's anything else. These warning overviews don't exactly tell you the relevant step/action it happened in.

@CodeWithShreyans
Copy link
Contributor

@Bo98 checkout my PR, seems to fix the cache issue.

issyl0 added a commit to issyl0/brew that referenced this issue Apr 2, 2023
- We forgot about this workflow when we bumped the versions of our
  actual workflows in Homebrew#14692.
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants