-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging homebrew-core and linuxbrew-core #7028
Comments
@sjackman I would like to make gcc@5 the main gcc formula on linux. |
As of #7280 we've got an audit for legitimate |
My intuition is that on Linux |
Thanks, Issy! |
This means that we need os-dependent aliases. Not sure I like that idea. And I still think it is surprising to |
I'm with @iMichka that I think the cleanest solution is probably to make the |
Makes sense. I'm on board. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Short status update, as some huge progress has been made lately:
|
There was a proposal from @SMillerDev to start adding linux bottles and more CI to homebrew-core as the migration is ongoing. Initially I was thinking to add all the bottles in one step at the end of the migration; but we can also take a step-by-step approach. We can not re-use linuxbrew-core bottles as-is, as the revisions are sometimes different there.
Thoughts? |
I think the best option to have would be:
Second best option:
Worst option:
|
The first option looks great, but how can we know on which bintray account the Linux bottle actually is? This will become irrelevant when we merge the core taps together, but for now I think it would be a problem that needs to be sorted out first. |
I like this option. |
I'd imagine we can try the main one and fall back if it fails? |
I would go for second option. It's less work, and probably easier to handle. We just need to think about the final migration when we flip the switch, but that's all. |
Yup 👍🏻
Fine with me.
Will likely be some custom
Personally: I don't think it's worth worrying about this. We should probably avoid deleting these bottles but I don't see any need to write code to make them work better. |
Oh and: great work on this @iMichka! |
Ok. I'll work on setting up linux bottling in homebrew-core soon for a few main formulae. I think the same rule will apply to homebrew-core as linuxbrew-core: if a formula has a linux bottle, any revision bump or version bump should build a new bottle. If there is no bottle, nothing happens (no linux CI) to that formula. I'll start working on this once I am done with the self-hosted runners project, unless someone wants to pick this up earlier. |
The xorg migration is done! |
Another step done: cellar information for specific platforms in bottle blocks is now merged! |
All done here. Users were migrated to homebrew-core with release 3.3.0. There is still an issue open at Homebrew/formulae.brew.sh#566 but it is being worked on. Closing here. |
Congratulations on the completion of this huge effort. Great work @iMichka and all. |
Eventually we may want to merge homebrew-core and linuxbrew-core. Even if not, minimising the diff between these repositories makes life easier for the linuxbrew-core maintainers.
To do this will require a few things (not in any particular order):
if OS.linux?
blocks (partly for readability and partly so these blocks can be parsed on macOS) likeuses_from_macos
e.g.def install
that's only run on a single platformcellar :any
to bottles on a single platform Allow platform-specific cellars in bottle blocks #9315: Reading (OK, bottle: tag specific cellars #10186), Writing (OK, Allow platform-specific cellars in bottle blocks #9315)Notes
The text was updated successfully, but these errors were encountered: